fix: fix quotes test (@rizwanmustafa)#8072
Open
rizwanmustafa wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
waiting for review
rizwanmustafa
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the QuotesController “isSubmissionEnabled” test case so the disabled-quotes scenario actually disables quote submissions and asserts the correct response.
Changes:
- Ensure the “quotes disabled” test sets
submissionsEnabledtofalse. - Update expected response payload to
"Quote submission disabled"andisEnabled: false.
| }); | ||
| it("should return for quotes disabled without authentication", async () => { | ||
| //GIVEN | ||
| enableQuotes(false); |
Member
|
hi,
nevermind, i'll create a pr for that |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
Bot
added
waiting for update
Member
Author
Don't worry. I will add that into this PR. |
github-actions
Bot
removed
the
waiting for update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a duplicate test.